OSDN Git Service

at86rf230: remove invalid max frame retries check
authorAlexander Aring <alex.aring@gmail.com>
Wed, 12 Nov 2014 02:37:04 +0000 (03:37 +0100)
committerMarcel Holtmann <marcel@holtmann.org>
Wed, 12 Nov 2014 04:10:42 +0000 (05:10 +0100)
This patch removes the invalid max frame retries check from driver
layer. This is already handled by nl802154 framework. Also the IEEE
802.15.4 standard doesn't allow a frame retries setting above 7. This
seems to be valid for the at86rf230 transceiver but the chip running out
of spec then. We only allow settings according 802.15.4 right now.

Signed-off-by: Alexander Aring <alex.aring@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
drivers/net/ieee802154/at86rf230.c

index aea00d3..31d62f9 100644 (file)
@@ -1184,9 +1184,6 @@ at86rf230_set_frame_retries(struct ieee802154_hw *hw, s8 retries)
        struct at86rf230_local *lp = hw->priv;
        int rc = 0;
 
-       if (retries < -1 || retries > 15)
-               return -EINVAL;
-
        lp->tx_aret = retries >= 0;
        lp->max_frame_retries = retries;