OSDN Git Service

nfp: bpf: reject TC offload if XDP loaded
authorJakub Kicinski <jakub.kicinski@netronome.com>
Thu, 2 Nov 2017 08:31:31 +0000 (01:31 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 2 Nov 2017 11:27:11 +0000 (20:27 +0900)
Recent TC changes dropped the check protecting us from trying
to offload a TC program if XDP programs are already loaded.

Fixes: 90d97315b3e7 ("nfp: bpf: Convert ndo_setup_tc offloads to block callbacks")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/netronome/nfp/bpf/main.c

index 04424db..8e3e89c 100644 (file)
@@ -130,6 +130,9 @@ static int nfp_bpf_setup_tc_block_cb(enum tc_setup_type type,
                    cls_bpf->common.protocol != htons(ETH_P_ALL) ||
                    cls_bpf->common.chain_index)
                        return -EOPNOTSUPP;
+               if (nn->dp.bpf_offload_xdp)
+                       return -EBUSY;
+
                return nfp_net_bpf_offload(nn, cls_bpf);
        default:
                return -EOPNOTSUPP;