OSDN Git Service

pinctrl: amd: Use generic_handle_irq_safe()
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Mon, 19 Sep 2022 12:42:54 +0000 (14:42 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Mon, 19 Sep 2022 13:08:38 +0000 (15:08 +0200)
On PREEMPT_RT enabled kernels the demultiplex interrupt handler is force
threaded and runs with interrupts enabled. The invocation of
generic_handle_domain_irq() with interrupts enabled triggers a lockdep
warning due to a non-irq safe lock acquisition.

Instead of disabling interrupts on the driver level, use
generic_handle_domain_irq_safe().

[ tglx: Split out from combo patch ]

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/YnkfWFzvusFFktSt@linutronix.de
Link: https://bugzilla.kernel.org/show_bug.cgi?id=215954
drivers/pinctrl/pinctrl-amd.c

index 4691a33..4ed2b4b 100644 (file)
@@ -639,7 +639,7 @@ static bool do_amd_gpio_irq_handler(int irq, void *dev_id)
                        if (!(regval & PIN_IRQ_PENDING) ||
                            !(regval & BIT(INTERRUPT_MASK_OFF)))
                                continue;
-                       generic_handle_domain_irq(gc->irq.domain, irqnr + i);
+                       generic_handle_domain_irq_safe(gc->irq.domain, irqnr + i);
 
                        /* Clear interrupt.
                         * We must read the pin register again, in case the