OSDN Git Service

greybus: operation: Drop alignment attribute from operation message header
authorViresh Kumar <viresh.kumar@linaro.org>
Wed, 29 Jul 2015 06:12:53 +0000 (11:42 +0530)
committerGreg Kroah-Hartman <gregkh@google.com>
Tue, 4 Aug 2015 02:57:40 +0000 (19:57 -0700)
The buffers allocated for message header is already 64 bit aligned and
we have explicit pad bytes in the header structure, to 64 bit align the
operation specific data.

And so there is no need to add the aligned attribute to the operation
message header. Drop it.

Suggested-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Alex Elder <elder@linaro.org>
Reviewed-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
drivers/staging/greybus/operation.h

index 00189e9..1b7cc6a 100644 (file)
@@ -62,7 +62,7 @@ enum gb_operation_result {
  *
  * The wire format for all numeric fields in the header is little
  * endian.  Any operation-specific data begins immediately after the
- * header, and is 64-bit aligned.
+ * header.
  */
 struct gb_operation_msg_hdr {
        __le16  size;           /* Size in bytes of header + payload */
@@ -70,7 +70,7 @@ struct gb_operation_msg_hdr {
        __u8    type;           /* E.g GB_I2C_TYPE_* or GB_GPIO_TYPE_* */
        __u8    result;         /* Result of request (in responses only) */
        __u8    pad[2];         /* must be zero (ignore when read) */
-} __aligned(sizeof(u64));
+};
 
 #define GB_OPERATION_MESSAGE_SIZE_MIN  sizeof(struct gb_operation_msg_hdr)
 #define GB_OPERATION_MESSAGE_SIZE_MAX  U16_MAX