OSDN Git Service

media: staging: rkisp1: capture: set default quantization on 'set_fmt'
authorDafna Hirschfeld <dafna.hirschfeld@collabora.com>
Mon, 26 Oct 2020 16:28:48 +0000 (17:28 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 16 Nov 2020 09:31:08 +0000 (10:31 +0100)
On 's/try_fmt' ioctl, set the quantization field to
V4L2_QUANTIZATION_DEFAULT. This fixes the compliance
errors:

fail: v4l2-test-formats.cpp(357): quantization >= 0xff
fail: v4l2-test-formats.cpp(473): testColorspace(!node->is_io_mc, pix_mp.pixelformat, pix_mp.colorspace, pix_mp.ycbcr_enc, pix_mp.quantization)
test VIDIOC_TRY_FMT: FAIL
fail: v4l2-test-formats.cpp(357): quantization >= 0xff
fail: v4l2-test-formats.cpp(473): testColorspace(!node->is_io_mc, pix_mp.pixelformat, pix_mp.colorspace, pix_mp.ycbcr_enc, pix_mp.quantization)
test VIDIOC_S_FMT: FAIL

Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Acked-by: Helen Koike <helen.koike@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/rkisp1/rkisp1-capture.c

index 9b4a12e..1c0f792 100644 (file)
@@ -1133,6 +1133,7 @@ static void rkisp1_try_fmt(const struct rkisp1_capture *cap,
        pixm->field = V4L2_FIELD_NONE;
        pixm->colorspace = V4L2_COLORSPACE_DEFAULT;
        pixm->ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT;
+       pixm->quantization = V4L2_QUANTIZATION_DEFAULT;
 
        info = rkisp1_fill_pixfmt(pixm, cap->id);