OSDN Git Service

scripts: report on author emails that are mangled by the mailing list
authorDaniel P. Berrangé <berrange@redhat.com>
Thu, 23 Aug 2018 10:21:43 +0000 (11:21 +0100)
committerDaniel P. Berrangé <berrange@redhat.com>
Wed, 31 Oct 2018 11:31:08 +0000 (11:31 +0000)
In some cases the Author: email address in patches submitted to the
list gets mangled such that it says

    John Doe via Qemu-devel <qemu-devel@nongnu.org>

This change is a result of workarounds for DMARC policies.

Subsystem maintainers accepting patches need to catch these and fix
them before sending pull requests, so a checkpatch.pl test is highly
desirable.

Reviewed-by: Eric Blake <eblake@redhat.com>
Acked-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
scripts/checkpatch.pl

index 3765b0e..06ec14e 100755 (executable)
@@ -1402,6 +1402,10 @@ sub process {
                        $is_patch = 1;
                }
 
+               if ($line =~ /^Author: .*via Qemu-devel.*<qemu-devel\@nongnu.org>/) {
+                   ERROR("Author email address is mangled by the mailing list\n" . $herecurr);
+               }
+
 #check the patch for a signoff:
                if ($line =~ /^\s*signed-off-by:/i) {
                        # This is a signoff, if ugly, so do not double report.