OSDN Git Service

Fix a crash in SystemUI when using CarNavigationBar.
authorRakesh Iyer <rni@google.com>
Tue, 9 Feb 2016 18:51:50 +0000 (10:51 -0800)
committerRakesh Iyer <rni@google.com>
Tue, 9 Feb 2016 18:51:50 +0000 (10:51 -0800)
CarNavigationBar overrides getCurrentView() in phone NavigationBarView
but the dump() method in NavigationBarView uses mCurrentView directly,
which may be null in the auto case. Callign getCurrentView() returns
the correct overriden view.

This patch makes the change to dump() to use getCurrentView().

Bug: 27046536
Change-Id: I92e5655325247d27faac1e33d8622783652bdb10

packages/SystemUI/src/com/android/systemui/statusbar/phone/NavigationBarView.java

index 5f5974e..0febbd2 100644 (file)
@@ -738,9 +738,9 @@ public class NavigationBarView extends LinearLayout {
                 + (offscreen ? " OFFSCREEN!" : ""));
 
         pw.println(String.format("      mCurrentView: id=%s (%dx%d) %s",
-                        getResourceName(mCurrentView.getId()),
-                        mCurrentView.getWidth(), mCurrentView.getHeight(),
-                        visibilityToString(mCurrentView.getVisibility())));
+                        getResourceName(getCurrentView().getId()),
+                        getCurrentView().getWidth(), getCurrentView().getHeight(),
+                        visibilityToString(getCurrentView().getVisibility())));
 
         pw.println(String.format("      disabled=0x%08x vertical=%s menu=%s",
                         mDisabledFlags,