OSDN Git Service
(root)
/
uclinux-h8
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
7cbef58
)
scsi: lpfc: Fix duplicate wq_create_version check
author
James Smart
<james.smart@broadcom.com>
Tue, 20 Oct 2020 20:27:15 +0000
(13:27 -0700)
committer
Martin K. Petersen
<martin.petersen@oracle.com>
Tue, 27 Oct 2020 01:42:38 +0000
(21:42 -0400)
During code reviews duplicate code sections were found to determine the WQ
Create version. The duplication was potentially overriding logic that
validated page size.
Link:
https://lore.kernel.org/r/20201020202719.54726-6-james.smart@broadcom.com
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/lpfc/lpfc_sli.c
patch
|
blob
|
history
diff --git
a/drivers/scsi/lpfc/lpfc_sli.c
b/drivers/scsi/lpfc/lpfc_sli.c
index
e5a7cfa
..
eaa5fb5
100644
(file)
--- a/
drivers/scsi/lpfc/lpfc_sli.c
+++ b/
drivers/scsi/lpfc/lpfc_sli.c
@@
-15893,12
+15893,6
@@
lpfc_wq_create(struct lpfc_hba *phba, struct lpfc_queue *wq,
else
wq_create_version = LPFC_Q_CREATE_VERSION_0;
-
- if (phba->sli4_hba.pc_sli4_params.wqsize & LPFC_WQ_SZ128_SUPPORT)
- wq_create_version = LPFC_Q_CREATE_VERSION_1;
- else
- wq_create_version = LPFC_Q_CREATE_VERSION_0;
-
switch (wq_create_version) {
case LPFC_Q_CREATE_VERSION_1:
bf_set(lpfc_mbx_wq_create_wqe_count, &wq_create->u.request_1,