OSDN Git Service

spi: don't open code list_for_each_entry_safe_reverse()
authorVladimir Zapolskiy <vz@mleia.com>
Tue, 18 Jun 2019 16:28:18 +0000 (19:28 +0300)
committerMark Brown <broonie@kernel.org>
Tue, 18 Jun 2019 18:19:14 +0000 (19:19 +0100)
The loop declaration in function spi_res_release() can be simplified
by reusing the common list_for_each_entry_safe_reverse() helper
macro.

Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi.c

index e71881a..01a40bc 100644 (file)
@@ -2721,12 +2721,9 @@ EXPORT_SYMBOL_GPL(spi_res_add);
  */
 void spi_res_release(struct spi_controller *ctlr, struct spi_message *message)
 {
-       struct spi_res *res;
-
-       while (!list_empty(&message->resources)) {
-               res = list_last_entry(&message->resources,
-                                     struct spi_res, entry);
+       struct spi_res *res, *tmp;
 
+       list_for_each_entry_safe_reverse(res, tmp, &message->resources, entry) {
                if (res->release)
                        res->release(ctlr, message, res->data);