OSDN Git Service

ASoC: atmel: Add missing of_node_put() in at91sam9g20ek_audio_probe
authorMiaoqian Lin <linmq006@gmail.com>
Mon, 7 Mar 2022 12:45:39 +0000 (12:45 +0000)
committerMark Brown <broonie@kernel.org>
Mon, 7 Mar 2022 13:14:50 +0000 (13:14 +0000)
This node pointer is returned by of_parse_phandle() with refcount
incremented in this function.
Calling of_node_put() to avoid the refcount leak.

Fixes: 531f67e41dcd ("ASoC: at91sam9g20ek-wm8731: convert to dt support")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Link: https://lore.kernel.org/r/20220307124539.1743-1-linmq006@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/atmel/sam9g20_wm8731.c

index 915da92..33e4301 100644 (file)
@@ -214,6 +214,7 @@ static int at91sam9g20ek_audio_probe(struct platform_device *pdev)
        cpu_np = of_parse_phandle(np, "atmel,ssc-controller", 0);
        if (!cpu_np) {
                dev_err(&pdev->dev, "dai and pcm info missing\n");
+               of_node_put(codec_np);
                return -EINVAL;
        }
        at91sam9g20ek_dai.cpus->of_node = cpu_np;