OSDN Git Service

attrib: Remove norequests and noresponses variables
authorJaganath Kanakkassery <jaganath.k@samsung.com>
Mon, 1 Apr 2013 09:38:00 +0000 (15:08 +0530)
committerJohan Hedberg <johan.hedberg@intel.com>
Tue, 2 Apr 2013 06:47:12 +0000 (09:47 +0300)
Passing NULL is fine to g_queue_is_empty(), so removing these
variables makes the code more readable

attrib/gattrib.c

index 01c19f9..f95f2fb 100644 (file)
@@ -394,7 +394,6 @@ static gboolean received_data(GIOChannel *io, GIOCondition cond, gpointer data)
        uint8_t buf[512], status;
        gsize len;
        GIOStatus iostat;
-       gboolean norequests, noresponses;
 
        if (attrib->stale)
                return FALSE;
@@ -447,11 +446,6 @@ static gboolean received_data(GIOChannel *io, GIOCondition cond, gpointer data)
        status = 0;
 
 done:
-       norequests = attrib->requests == NULL ||
-                       g_queue_is_empty(attrib->requests);
-       noresponses = attrib->responses == NULL ||
-                       g_queue_is_empty(attrib->responses);
-
        if (cmd) {
                if (cmd->func)
                        cmd->func(status, buf, len, cmd->user_data);
@@ -459,7 +453,8 @@ done:
                command_destroy(cmd);
        }
 
-       if (!norequests || !noresponses)
+       if (!g_queue_is_empty(attrib->requests) ||
+                                       !g_queue_is_empty(attrib->responses))
                wake_up_sender(attrib);
 
        return TRUE;