OSDN Git Service

drm/amdgpu: update parameter of ras_ih_cb
authorTao Zhou <tao.zhou1@amd.com>
Thu, 12 Sep 2019 05:38:44 +0000 (13:38 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 3 Oct 2019 14:11:01 +0000 (09:11 -0500)
change struct ras_err_data *err_data to void *err_data, align with
umc code and the callback's declaration in each ras block could
pay no attention to the structure type

Signed-off-by: Tao Zhou <tao.zhou1@amd.com>
Reviewed-by: Guchun Chen <guchun.chen@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c

index ae386c4..f80fd34 100644 (file)
@@ -362,7 +362,7 @@ struct ras_err_handler_data {
 };
 
 typedef int (*ras_ih_cb)(struct amdgpu_device *adev,
-               struct ras_err_data *err_data,
+               void *err_data,
                struct amdgpu_iv_entry *entry);
 
 struct ras_ih_data {
index 5365b30..bced313 100644 (file)
@@ -4204,7 +4204,7 @@ static int gfx_v9_0_early_init(void *handle)
 }
 
 static int gfx_v9_0_process_ras_data_cb(struct amdgpu_device *adev,
-               struct ras_err_data *err_data,
+               void *err_data,
                struct amdgpu_iv_entry *entry);
 
 static int gfx_v9_0_ecc_late_init(void *handle)
@@ -5457,7 +5457,7 @@ static int gfx_v9_0_priv_inst_irq(struct amdgpu_device *adev,
 }
 
 static int gfx_v9_0_process_ras_data_cb(struct amdgpu_device *adev,
-               struct ras_err_data *err_data,
+               void *err_data,
                struct amdgpu_iv_entry *entry)
 {
        /* TODO ue will trigger an interrupt. */
index 7f6536c..8910a18 100644 (file)
@@ -246,16 +246,18 @@ static int gmc_v9_0_ecc_interrupt_state(struct amdgpu_device *adev,
 }
 
 static int gmc_v9_0_process_ras_data_cb(struct amdgpu_device *adev,
-               struct ras_err_data *err_data,
+               void *ras_error_status,
                struct amdgpu_iv_entry *entry)
 {
+       struct ras_err_data *err_data = (struct ras_err_data *)ras_error_status;
+
        if (amdgpu_ras_is_supported(adev, AMDGPU_RAS_BLOCK__GFX))
                return AMDGPU_RAS_SUCCESS;
 
        kgd2kfd_set_sram_ecc_flag(adev->kfd.dev);
        if (adev->umc.funcs &&
            adev->umc.funcs->query_ras_error_count)
-           adev->umc.funcs->query_ras_error_count(adev, err_data);
+           adev->umc.funcs->query_ras_error_count(adev, ras_error_status);
 
        if (adev->umc.funcs &&
            adev->umc.funcs->query_ras_error_address &&
index 265b9c0..ae098e2 100644 (file)
@@ -1690,7 +1690,7 @@ static int sdma_v4_0_early_init(void *handle)
 }
 
 static int sdma_v4_0_process_ras_data_cb(struct amdgpu_device *adev,
-               struct ras_err_data *err_data,
+               void *err_data,
                struct amdgpu_iv_entry *entry);
 
 static int sdma_v4_0_late_init(void *handle)
@@ -1939,7 +1939,7 @@ static int sdma_v4_0_process_trap_irq(struct amdgpu_device *adev,
 }
 
 static int sdma_v4_0_process_ras_data_cb(struct amdgpu_device *adev,
-               struct ras_err_data *err_data,
+               void *err_data,
                struct amdgpu_iv_entry *entry)
 {
        uint32_t err_source;