OSDN Git Service

netdevsim: make debug dirs' dentries static
authorJakub Kicinski <jakub.kicinski@netronome.com>
Thu, 26 Jul 2018 21:25:26 +0000 (14:25 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 27 Jul 2018 04:28:54 +0000 (21:28 -0700)
The root directories of netdevsim should only be used by the core
to create per-device subdirectories, so limit their visibility to
the core file.

Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/netdevsim/netdev.c
drivers/net/netdevsim/netdevsim.h

index 2d24455..8d8e2b3 100644 (file)
@@ -41,6 +41,9 @@ struct nsim_vf_config {
 
 static u32 nsim_dev_id;
 
+static struct dentry *nsim_ddir;
+static struct dentry *nsim_sdev_ddir;
+
 static int nsim_num_vf(struct device *dev)
 {
        struct netdevsim *ns = to_nsim(dev);
@@ -566,9 +569,6 @@ static struct rtnl_link_ops nsim_link_ops __read_mostly = {
        .dellink        = nsim_dellink,
 };
 
-struct dentry *nsim_ddir;
-struct dentry *nsim_sdev_ddir;
-
 static int __init nsim_module_init(void)
 {
        int err;
index 02be199..384c254 100644 (file)
@@ -103,9 +103,6 @@ struct netdevsim {
        struct nsim_ipsec ipsec;
 };
 
-extern struct dentry *nsim_ddir;
-extern struct dentry *nsim_sdev_ddir;
-
 #ifdef CONFIG_BPF_SYSCALL
 int nsim_bpf_init(struct netdevsim *ns);
 void nsim_bpf_uninit(struct netdevsim *ns);