OSDN Git Service

m68k: coldfire: return success for clk_enable(NULL)
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 29 Jul 2021 12:27:03 +0000 (15:27 +0300)
committerGreg Ungerer <gerg@linux-m68k.org>
Sun, 22 Aug 2021 22:40:04 +0000 (08:40 +1000)
The clk_enable is supposed work when CONFIG_HAVE_CLK is false, but it
returns -EINVAL.  That means some drivers fail during probe.

[    1.680000] flexcan: probe of flexcan.0 failed with error -22

Fixes: c1fb1bf64bb6 ("m68k: let clk_enable() return immediately if clk is NULL")
Fixes: bea8bcb12da0 ("m68knommu: Add support for the Coldfire m5441x.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Greg Ungerer <gerg@linux-m68k.org>
arch/m68k/coldfire/clk.c

index 2ed841e..d03b6c4 100644 (file)
@@ -78,7 +78,7 @@ int clk_enable(struct clk *clk)
        unsigned long flags;
 
        if (!clk)
-               return -EINVAL;
+               return 0;
 
        spin_lock_irqsave(&clk_lock, flags);
        if ((clk->enabled++ == 0) && clk->clk_ops)