OSDN Git Service

firmware: arm_scmi: Clear stale xfer->hdr.status
authorCristian Marussi <cristian.marussi@arm.com>
Thu, 22 Dec 2022 18:38:19 +0000 (18:38 +0000)
committerSudeep Holla <sudeep.holla@arm.com>
Tue, 3 Jan 2023 16:50:29 +0000 (16:50 +0000)
Stale error status reported from a previous message transaction must be
cleared before starting a new transaction to avoid being confusingly
reported in the following SCMI message dump traces.

Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
Link: https://lore.kernel.org/r/20221222183823.518856-2-cristian.marussi@arm.com
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
drivers/firmware/arm_scmi/driver.c

index f818d00..ffdad59 100644 (file)
@@ -910,6 +910,8 @@ static int do_xfer(const struct scmi_protocol_handle *ph,
                              xfer->hdr.protocol_id, xfer->hdr.seq,
                              xfer->hdr.poll_completion);
 
+       /* Clear any stale status */
+       xfer->hdr.status = SCMI_SUCCESS;
        xfer->state = SCMI_XFER_SENT_OK;
        /*
         * Even though spinlocking is not needed here since no race is possible