Fix clang-tidy performance-* warnings in system/extras.

* Use const reference parameter type to avoid unnecessary copy.
* Use more efficient overloaded string methods.

Bug: 30407689
Bug: 30411878
Test: build with WITH_TIDY=1
Change-Id: I558d482910c8a53c042d876848e35cdce8b8c15b

diff --git a/multinetwork/httpurl.cpp b/multinetwork/httpurl.cpp
index e079c1d..d78c0c9 100644 (file)
--- a/multinetwork/httpurl.cpp
+++ b/multinetwork/httpurl.cpp
@@ -52,7 +52,7 @@ bool parseUrl(const struct Arguments& args, struct Parameters* parameters) {
     }
 
     parameters->host = std::string(args.arg1).substr(strlen(HTTP_PREFIX));
-    const auto first_slash = parameters->host.find_first_of("/");
+    const auto first_slash = parameters->host.find_first_of('/');
     if (first_slash != std::string::npos) {
         parameters->path = parameters->host.substr(first_slash);
         parameters->host.erase(first_slash);
@@ -64,7 +64,7 @@ bool parseUrl(const struct Arguments& args, struct Parameters* parameters) {
     }
 
     if (parameters->host[0] == '[') {
-        const auto closing_bracket = parameters->host.find_first_of("]");
+        const auto closing_bracket = parameters->host.find_first_of(']');
         if (closing_bracket == std::string::npos) {
             std::cerr << "Missing closing bracket." << std::endl;
             return false;
@@ -80,7 +80,7 @@ bool parseUrl(const struct Arguments& args, struct Parameters* parameters) {
             parameters->port = parameters->host.substr(closing_bracket + 2);
         }
     } else {
-        const auto first_colon = parameters->host.find_first_of(":");
+        const auto first_colon = parameters->host.find_first_of(':');
         if (first_colon != std::string::npos) {
             parameters->port = parameters->host.substr(first_colon + 1);
             parameters->hostname = parameters->host.substr(0, first_colon);

diff --git a/simpleperf/cmd_kmem.cpp b/simpleperf/cmd_kmem.cpp
index 51f9a58..65ad323 100644 (file)
--- a/simpleperf/cmd_kmem.cpp
+++ b/simpleperf/cmd_kmem.cpp
@@ -113,7 +113,7 @@ struct SlabFormat {
 class SlabSampleTreeBuilder
     : public SampleTreeBuilder<SlabSample, SlabAccumulateInfo> {
  public:
-  SlabSampleTreeBuilder(SampleComparator<SlabSample> sample_comparator,
+  SlabSampleTreeBuilder(const SampleComparator<SlabSample>& sample_comparator,
                         ThreadTree* thread_tree)
       : SampleTreeBuilder(sample_comparator),
         thread_tree_(thread_tree),

diff --git a/simpleperf/cmd_report_test.cpp b/simpleperf/cmd_report_test.cpp
index 703ca8f..f274114 100644 (file)
--- a/simpleperf/cmd_report_test.cpp
+++ b/simpleperf/cmd_report_test.cpp
@@ -459,7 +459,7 @@ TEST_F(ReportCommandTest, raw_period_option) {
   Report(PERF_DATA, {"--raw-period"});
   ASSERT_TRUE(success);
   ASSERT_NE(content.find("GlobalFunc"), std::string::npos);
-  ASSERT_EQ(content.find("%"), std::string::npos);
+  ASSERT_EQ(content.find('%'), std::string::npos);
 }
 
 TEST_F(ReportCommandTest, full_callgraph_option) {

diff --git a/simpleperf/environment.cpp b/simpleperf/environment.cpp
index 604798a..79280d1 100644 (file)
--- a/simpleperf/environment.cpp
+++ b/simpleperf/environment.cpp
@@ -549,7 +549,7 @@ int WaitForAppProcess(const std::string& package_name) {
 
 class ScopedFile {
  public:
-  ScopedFile(const std::string& filepath, std::string app_package_name = "")
+  ScopedFile(const std::string& filepath, const std::string& app_package_name = "")
       : filepath_(filepath), app_package_name_(app_package_name) {}
 
   ~ScopedFile() {

diff --git a/simpleperf/read_apk.h b/simpleperf/read_apk.h
index 65b5df8..8aaae67 100644 (file)
--- a/simpleperf/read_apk.h
+++ b/simpleperf/read_apk.h
@@ -35,8 +35,8 @@ class EmbeddedElf {
   {
   }
 
-  EmbeddedElf(std::string filepath,
-              std::string entry_name,
+  EmbeddedElf(const std::string& filepath,
+              const std::string& entry_name,
               size_t entry_offset,
               size_t entry_size)
       : filepath_(filepath)