OSDN Git Service

bnxt: reject unsupported coalescing params
authorJakub Kicinski <kuba@kernel.org>
Thu, 5 Mar 2020 05:15:39 +0000 (21:15 -0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 5 Mar 2020 20:12:35 +0000 (12:12 -0800)
Set ethtool_ops->supported_coalesce_params to let
the core reject unsupported coalescing parameters.

This driver did not previously reject unsupported parameters.

v3: adjust commit message for new member name

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c

index 7e84f1d..1fa3a12 100644 (file)
@@ -3472,6 +3472,12 @@ void bnxt_ethtool_free(struct bnxt *bp)
 }
 
 const struct ethtool_ops bnxt_ethtool_ops = {
+       .supported_coalesce_params = ETHTOOL_COALESCE_USECS |
+                                    ETHTOOL_COALESCE_MAX_FRAMES |
+                                    ETHTOOL_COALESCE_USECS_IRQ |
+                                    ETHTOOL_COALESCE_MAX_FRAMES_IRQ |
+                                    ETHTOOL_COALESCE_STATS_BLOCK_USECS |
+                                    ETHTOOL_COALESCE_USE_ADAPTIVE_RX,
        .get_link_ksettings     = bnxt_get_link_ksettings,
        .set_link_ksettings     = bnxt_set_link_ksettings,
        .get_pauseparam         = bnxt_get_pauseparam,