OSDN Git Service

media: i2c: adv7180: Print the chip ID on probe
authorFabio Estevam <festevam@gmail.com>
Mon, 31 May 2021 11:22:37 +0000 (13:22 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 22 Jul 2021 09:40:46 +0000 (11:40 +0200)
Improve the probe message by printing the chip ID version.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/i2c/adv7180.c

index 83690d4..81dd9eb 100644 (file)
@@ -1415,11 +1415,19 @@ static int adv7180_probe(struct i2c_client *client,
        if (ret)
                goto err_free_irq;
 
-       v4l_info(client, "chip found @ 0x%02x (%s)\n",
-                client->addr, client->adapter->name);
+       mutex_lock(&state->mutex);
+       ret = adv7180_read(state, ADV7180_REG_IDENT);
+       mutex_unlock(&state->mutex);
+       if (ret < 0)
+               goto err_v4l2_async_unregister;
+
+       v4l_info(client, "chip id 0x%x found @ 0x%02x (%s)\n",
+                ret, client->addr, client->adapter->name);
 
        return 0;
 
+err_v4l2_async_unregister:
+       v4l2_async_unregister_subdev(sd);
 err_free_irq:
        if (state->irq > 0)
                free_irq(client->irq, state);