OSDN Git Service

Staging: speakup: Remove unused variable
authorHaneen Mohammed <hamohammed.sa@gmail.com>
Sat, 7 Mar 2015 21:03:51 +0000 (00:03 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 9 Mar 2015 12:30:40 +0000 (13:30 +0100)
This patch removes variable that was used to store only the return value of a function call.

The issue was detected and resolved using the following coccinelle script:

@@
expression ret;
identifier f;
@@

 -ret =
 +return
    f(...);
 -return ret;

Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/speakup/kobjects.c

index 3708bc1..0211df6 100644 (file)
@@ -840,12 +840,10 @@ static ssize_t message_show(struct kobject *kobj,
 static ssize_t message_store(struct kobject *kobj, struct kobj_attribute *attr,
        const char *buf, size_t count)
 {
-       ssize_t retval = 0;
        struct msg_group_t *group = spk_find_msg_group(attr->attr.name);
 
        BUG_ON(!group);
-       retval = message_store_helper(buf, count, group);
-       return retval;
+       return message_store_helper(buf, count, group);
 }
 
 /*