This patch fixes the well-known but unfixed bug that fetchone() always returns

the first result in the DB-API compliant wrapper. It turned out that the bug
was way down in the C code.

Gerhard Häring

diff --git a/src/interfaces/python/pgmodule.c b/src/interfaces/python/pgmodule.c
index 98da364..38ae733 100644 (file)
--- a/src/interfaces/python/pgmodule.c
+++ b/src/interfaces/python/pgmodule.c
@@ -548,13 +548,13 @@ pgsource_fetch(pgsourceobject * self, PyObject * args)
 
                for (j = 0; j < self->num_fields; j++)
                {
-                       if (PQgetisnull(self->last_result, i, j))
+                       if (PQgetisnull(self->last_result, self->current_row, j))
                        {
                                Py_INCREF(Py_None);
                                str = Py_None;
                        }
                        else
-                               str = PyString_FromString(PQgetvalue(self->last_result, i, j));
+                               str = PyString_FromString(PQgetvalue(self->last_result, self->current_row, j));
 
                        PyTuple_SET_ITEM(rowtuple, j, str);
                }