OSDN Git Service
(root)
/
uclinux-h8
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
a20ca67
)
drm/etnaviv: NULL vs IS_ERR() buf in etnaviv_core_dump()
author
Dan Carpenter
<dan.carpenter@oracle.com>
Mon, 14 Jan 2019 10:49:46 +0000
(13:49 +0300)
committer
Lucas Stach
<l.stach@pengutronix.de>
Wed, 16 Jan 2019 15:29:12 +0000
(16:29 +0100)
The etnaviv_gem_get_pages() never returns NULL. It returns error
pointers on error.
Fixes:
a8c21a5451d8
("drm/etnaviv: add initial etnaviv DRM driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
drivers/gpu/drm/etnaviv/etnaviv_dump.c
patch
|
blob
|
history
diff --git
a/drivers/gpu/drm/etnaviv/etnaviv_dump.c
b/drivers/gpu/drm/etnaviv/etnaviv_dump.c
index
3fbb485
..
33854c9
100644
(file)
--- a/
drivers/gpu/drm/etnaviv/etnaviv_dump.c
+++ b/
drivers/gpu/drm/etnaviv/etnaviv_dump.c
@@
-215,7
+215,7
@@
void etnaviv_core_dump(struct etnaviv_gpu *gpu)
mutex_lock(&obj->lock);
pages = etnaviv_gem_get_pages(obj);
mutex_unlock(&obj->lock);
- if (
pages
) {
+ if (
!IS_ERR(pages)
) {
int j;
iter.hdr->data[0] = bomap - bomap_start;