OSDN Git Service

various cleanups
authorIvailo Monev <xakepa10@laimg.moc>
Sun, 21 Aug 2016 12:46:27 +0000 (12:46 +0000)
committerIvailo Monev <xakepa10@laimg.moc>
Sun, 21 Aug 2016 18:37:25 +0000 (18:37 +0000)
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
39 files changed:
src/core/io/qfilesystemwatcher_fsevents.cpp
src/core/io/qfilesystemwatcher_kqueue.cpp
src/core/io/qfsfileengine_unix.cpp
src/core/io/qfsfileengine_win.cpp
src/core/io/qurl.cpp
src/core/statemachine/qabstractstate.cpp
src/core/statemachine/qabstractstate.h
src/core/statemachine/qeventtransition.cpp
src/core/statemachine/qeventtransition.h
src/core/statemachine/qfinalstate.cpp
src/core/statemachine/qfinalstate.h
src/core/statemachine/qhistorystate.cpp
src/core/statemachine/qhistorystate.h
src/core/statemachine/qsignaltransition.cpp
src/core/statemachine/qsignaltransition.h
src/core/thread/qwaitcondition.h
src/core/tools/qbytearray.cpp
src/core/tools/qelapsedtimer_generic.cpp
src/core/tools/qelapsedtimer_unix.cpp
src/dbus/qdbusconnection_p.h
src/dbus/qdbuserror.cpp
src/declarative/qml/qdeclarativecontext.cpp
src/declarative/qml/qdeclarativevme_p.h
src/gui/accessible/qaccessibleobject.cpp
src/gui/dialogs/qfiledialog_mac.mm
src/gui/graphicsview/qgraphicsitem.cpp
src/gui/graphicsview/qgraphicsscene.cpp
src/gui/image/qpixmapfilter.cpp
src/gui/painting/qpaintengine_mac.cpp
src/gui/painting/qpathclipper.cpp
src/gui/painting/qrasterizer.cpp
src/gui/text/qfontdatabase.cpp
src/gui/text/qfontengine_win.cpp
src/gui/text/qfontengineglyphcache_p.h
src/gui/text/qtextdocumentfragment_p.h
src/gui/widgets/qmainwindowlayout.cpp
src/opengl/gl2paintengineex/qpaintengineex_opengl2.cpp
src/opengl/gl2paintengineex/qtriangulator.cpp
src/opengl/qgl_wince.cpp

index abe5099..a3db6b4 100644 (file)
@@ -51,7 +51,6 @@
 #include <qfile.h>
 #include <qdatetime.h>
 #include <qfileinfo.h>
-#include <qvarlengtharray.h>
 
 #include <mach/mach.h>
 #include <sys/types.h>
index 7b4acc7..4a0987d 100644 (file)
@@ -50,7 +50,6 @@
 #include <qdebug.h>
 #include <qfile.h>
 #include <qsocketnotifier.h>
-#include <qvarlengtharray.h>
 
 #include <sys/types.h>
 #include <sys/event.h>
index 3f65382..237c831 100644 (file)
@@ -51,7 +51,6 @@
 #include "qfile.h"
 #include "qdir.h"
 #include "qdatetime.h"
-#include "qvarlengtharray.h"
 
 #include <sys/mman.h>
 #include <stdlib.h>
index 71c90a1..36097c7 100644 (file)
@@ -48,7 +48,6 @@
 
 #include "qfile.h"
 #include "qdir.h"
-#include "qvarlengtharray.h"
 #include "qdatetime.h"
 #include "qt_windows.h"
 
index 48f5bbb..dc69ae8 100644 (file)
 #include "qstring.h"
 #include "qstringlist.h"
 #include "qstack.h"
-#include "qvarlengtharray.h"
 #include "qdebug.h"
 #include "qlocale_tools_p.h"
 #ifndef QT_BOOTSTRAPPED
index 3f69f14..71ceb1f 100644 (file)
@@ -202,14 +202,6 @@ QStateMachine *QAbstractState::machine() const
   been called).
 */
 
-/*!
-  \reimp
-*/
-bool QAbstractState::event(QEvent *e)
-{
-    return QObject::event(e);
-}
-
 #include "moc_qabstractstate.h"
 
 QT_END_NAMESPACE
index 23ea010..cfa07c1 100644 (file)
@@ -76,8 +76,6 @@ protected:
     virtual void onEntry(QEvent *event) = 0;
     virtual void onExit(QEvent *event) = 0;
 
-    bool event(QEvent *e);
-
 protected:
     QAbstractState(QAbstractStatePrivate &dd, QState *parent);
 
index 87707fc..1a9f26b 100644 (file)
@@ -247,14 +247,6 @@ void QEventTransition::onTransition(QEvent *event)
     Q_UNUSED(event);
 }
 
-/*!
-  \reimp
-*/
-bool QEventTransition::event(QEvent *e)
-{
-    return QAbstractTransition::event(e);
-}
-
 QT_END_NAMESPACE
 
 #include "moc_qeventtransition.h"
index d4debdc..b6684c8 100644 (file)
@@ -73,8 +73,6 @@ protected:
     bool eventTest(QEvent *event);
     void onTransition(QEvent *event);
 
-    bool event(QEvent *e);
-
 protected:
     QEventTransition(QEventTransitionPrivate &dd, QState *parent);
     QEventTransition(QEventTransitionPrivate &dd, QObject *object,
index 708c473..116aba0 100644 (file)
@@ -127,14 +127,6 @@ void QFinalState::onExit(QEvent *event)
     Q_UNUSED(event);
 }
 
-/*!
-  \reimp
-*/
-bool QFinalState::event(QEvent *e)
-{
-    return QAbstractState::event(e);
-}
-
 #include "moc_qfinalstate.h"
 
 QT_END_NAMESPACE
index c207435..1ef1b3a 100644 (file)
@@ -63,8 +63,6 @@ protected:
     void onEntry(QEvent *event);
     void onExit(QEvent *event);
 
-    bool event(QEvent *e);
-
 private:
     Q_DISABLE_COPY(QFinalState)
     Q_DECLARE_PRIVATE(QFinalState)
index abc8435..7c4a03e 100644 (file)
@@ -217,14 +217,6 @@ void QHistoryState::onExit(QEvent *event)
     Q_UNUSED(event);
 }
 
-/*!
-  \reimp
-*/
-bool QHistoryState::event(QEvent *e)
-{
-    return QAbstractState::event(e);
-}
-
 #include "moc_qhistorystate.h"
 
 QT_END_NAMESPACE
index ad9143b..c6435c1 100644 (file)
@@ -78,8 +78,6 @@ protected:
     void onEntry(QEvent *event);
     void onExit(QEvent *event);
 
-    bool event(QEvent *e);
-
 private:
     Q_DISABLE_COPY(QHistoryState)
     Q_DECLARE_PRIVATE(QHistoryState)
index 3852d6b..da4808e 100644 (file)
@@ -236,14 +236,6 @@ void QSignalTransition::onTransition(QEvent *event)
     Q_UNUSED(event);
 }
 
-/*!
-  \reimp
-*/
-bool QSignalTransition::event(QEvent *e)
-{
-    return QAbstractTransition::event(e);
-}
-
 void QSignalTransitionPrivate::callOnTransition(QEvent *e)
 {
     Q_Q(QSignalTransition);
index f1fba18..2b83a60 100644 (file)
@@ -73,8 +73,6 @@ protected:
     bool eventTest(QEvent *event);
     void onTransition(QEvent *event);
 
-    bool event(QEvent *e);
-
 private:
     Q_DISABLE_COPY(QSignalTransition)
     Q_DECLARE_PRIVATE(QSignalTransition)
index 6fc48f5..8c0fcb2 100644 (file)
@@ -85,9 +85,9 @@ public:
 
     bool wait(QMutex *mutex, unsigned long time = ULONG_MAX)
     {
-       Q_UNUSED(mutex);
-       Q_UNUSED(time);
-       return true;
+        Q_UNUSED(mutex);
+        Q_UNUSED(time);
+        return true;
     }
 
     void wakeOne() {}
index 69a536b..59d901a 100644 (file)
@@ -135,10 +135,10 @@ char *qstrcpy(char *dst, const char *src)
         return 0;
 #if defined(_MSC_VER) && _MSC_VER >= 1400
     int len = qstrlen(src);
-       // This is actually not secure!!! It will be fixed
-       // properly in a later release!
+    // This is actually not secure!!! It will be fixed
+    // properly in a later release!
     if (len >= 0 && strcpy_s(dst, len+1, src) == 0)
-           return dst;
+        return dst;
     return 0;
 #else
     return strcpy(dst, src);
index 712de77..9a84136 100644 (file)
@@ -159,8 +159,7 @@ qint64 QElapsedTimer::msecsSinceReference() const
 */
 qint64 QElapsedTimer::msecsTo(const QElapsedTimer &other) const
 {
-    qint64 diff = other.t1 - t1;
-    return diff;
+    return other.t1 - t1;
 }
 
 /*!
index 8f16444..4809c19 100644 (file)
@@ -66,18 +66,13 @@ static int monotonicClockChecked = false;
 static int monotonicClockAvailable = false;
 #endif
 
-#ifdef Q_CC_GNU
-# define is_likely(x) __builtin_expect((x), 1)
-#else
-# define is_likely(x) (x)
-#endif
 #define load_acquire(x) ((volatile const int&)(x))
 #define store_release(x,v) ((volatile int&)(x) = (v))
 
-static void unixCheckClockType()
+static inline void unixCheckClockType()
 {
 #if (_POSIX_MONOTONIC_CLOCK-0 == 0)
-    if (is_likely(load_acquire(monotonicClockChecked)))
+    if (Q_LIKELY(load_acquire(monotonicClockChecked)))
         return;
 
 # if defined(_SC_MONOTONIC_CLOCK)
@@ -122,7 +117,7 @@ static inline void do_gettime(qint64 *sec, qint64 *frac)
 {
 #if (_POSIX_MONOTONIC_CLOCK-0 >= 0)
     unixCheckClockType();
-    if (is_likely(monotonicClockAvailable)) {
+    if (Q_LIKELY(monotonicClockAvailable)) {
         timespec ts;
         clock_gettime(CLOCK_MONOTONIC, &ts);
         *sec = ts.tv_sec;
index 656c699..43ea6ca 100644 (file)
@@ -64,7 +64,6 @@
 #include <QtCore/qpointer.h>
 #include <QtCore/qreadwritelock.h>
 #include <QtCore/qstringlist.h>
-#include <QtCore/qvarlengtharray.h>
 #include <QtCore/qvector.h>
 
 #include <qdbusmessage.h>
index 5318b9b..12cc102 100644 (file)
@@ -42,7 +42,6 @@
 #include "qdbuserror.h"
 
 #include <qdebug.h>
-#include <qvarlengtharray.h>
 
 #include "qdbusmessage.h"
 #include "qdbusmessage_p.h"
index 4cf7664..e28a399 100644 (file)
@@ -50,8 +50,7 @@
 #include "qdeclarativeglobalscriptclass_p.h"
 
 #include <qscriptengine.h>
-#include <QtCore/qvarlengtharray.h>
-#include <QtCore/qdebug.h>
+#include <qdebug.h>
 
 #include <qscriptdeclarativeclass_p.h>
 
index cc5e074..a730d84 100644 (file)
@@ -57,7 +57,6 @@
 
 #include <QtCore/QString>
 #include <QtCore/QStack>
-#include <QtCore/QVarLengthArray>
 
 QT_BEGIN_NAMESPACE
 
index 9a99b3c..0fe73fc 100644 (file)
@@ -47,7 +47,6 @@
 #include "qwidget.h"
 #include "qpointer.h"
 #include "qmetaobject.h"
-#include "qvarlengtharray.h"
 
 QT_BEGIN_NAMESPACE
 
index 8e714c2..2fbdaaa 100644 (file)
@@ -59,7 +59,6 @@
 #include <qstringlist.h>
 #include <qaction.h>
 #include <qtextcodec.h>
-#include <qvarlengtharray.h>
 #include <qdesktopwidget.h>
 #include <stdlib.h>
 #include <qabstracteventdispatcher.h>
index 423af2c..89f8119 100644 (file)
 #include <QtCore/qstack.h>
 #include <QtCore/qtimer.h>
 #include <QtCore/qvariant.h>
-#include <QtCore/qvarlengtharray.h>
 #include <QtCore/qnumeric.h>
 #include <QtGui/qapplication.h>
 #include <QtGui/qbitmap.h>
index 6c68e24..a3dc210 100644 (file)
 #include <QtCore/qset.h>
 #include <QtCore/qstack.h>
 #include <QtCore/qtimer.h>
-#include <QtCore/qvarlengtharray.h>
 #include <QtCore/qmetaobject.h>
 #include <QtGui/qapplication.h>
 #include <QtGui/qdesktopwidget.h>
index 9d9d7a7..f9cea1d 100644 (file)
@@ -46,7 +46,6 @@
 #include "qpainter.h"
 #include "qpixmap.h"
 #include "qpixmapfilter_p.h"
-#include "qvarlengtharray.h"
 
 #include "qapplication_p.h"
 #include "qgraphicssystem_p.h"
index 84667c9..c73691e 100644 (file)
@@ -50,7 +50,6 @@
 #include <qstack.h>
 #include <qtextcodec.h>
 #include <qwidget.h>
-#include <qvarlengtharray.h>
 #include <qdebug.h>
 #include <qcoreapplication.h>
 #include <qmath.h>
index ffa7437..b7dccb1 100644 (file)
@@ -42,7 +42,6 @@
 #include "qpathclipper_p.h"
 
 #include <qbezier_p.h>
-#include <qdatabuffer_p.h>
 #include <qnumeric_p.h>
 #include <qmath.h>
 
index 4c92e44..39c7bed 100644 (file)
@@ -188,8 +188,7 @@ private:
 
     QDataBuffer<Line *> m_active;
 
-    template <typename T>
-    friend void qScanConvert(QScanConverter &d, T allVertical);
+    friend void qScanConvert(QScanConverter &d, bool allVertical);
 };
 
 class QRasterizerPrivate
@@ -271,7 +270,7 @@ void QScanConverter::emitSpans(int chunk)
 
 // split control points b[0] ... b[3] into
 // left (b[0] ... b[3]) and right (b[3] ... b[6])
-static void split(QT_FT_Vector *b)
+static inline void split(QT_FT_Vector *b)
 {
     b[6] = b[3];
 
@@ -305,18 +304,8 @@ static inline bool xOrder(const QScanConverter::Line *a, const QScanConverter::L
     return a->x < b->x;
 }
 
-template <bool B>
-struct QBoolToType
-{
-    inline bool operator()() const
-    {
-        return B;
-    }
-};
-
 // should be a member function but VC6 doesn't support member template functions
-template <typename T>
-void qScanConvert(QScanConverter &d, T allVertical)
+void qScanConvert(QScanConverter &d, bool allVertical)
 {
     if (!d.m_lines.size()) {
         d.m_active.reset();
@@ -327,7 +316,7 @@ void qScanConvert(QScanConverter &d, T allVertical)
     for (int y = d.m_lines.first().top; y <= d.m_bottom; ++y) {
         for (; line < d.m_lines.size() && d.m_lines.at(line).top == y; ++line) {
             // add node to active list
-            if (allVertical()) {
+            if (allVertical) {
                 QScanConverter::Line *l = &d.m_lines.at(line);
                 d.m_active.resize(d.m_active.size() + 1);
                 int j;
@@ -340,7 +329,7 @@ void qScanConvert(QScanConverter &d, T allVertical)
         }
 
         int numActive = d.m_active.size();
-        if (!allVertical()) {
+        if (!allVertical) {
         // use insertion sort instead of qSort, as the active edge list is quite small
         // and in the average case already sorted
             for (int i = 1; i < numActive; ++i) {
@@ -371,7 +360,7 @@ void qScanConvert(QScanConverter &d, T allVertical)
 
                 d.m_active.resize(--numActive);
                 --i;
-            } else if (!allVertical())
+            } else if (!allVertical)
                 node->x += node->delta;
         }
     }
@@ -391,10 +380,7 @@ void QScanConverter::end()
                 break;
             }
         }
-        if (allVertical)
-            qScanConvert(*this, QBoolToType<true>());
-        else
-            qScanConvert(*this, QBoolToType<false>());
+        qScanConvert(*this, allVertical);
     } else {
         for (int chunkTop = m_top; chunkTop <= m_bottom; chunkTop += CHUNK_SIZE) {
             prepareChunk();
index 1226b85..9d668b3 100644 (file)
@@ -44,7 +44,6 @@
 #include "qdebug.h"
 #include "qalgorithms.h"
 #include "qapplication.h"
-#include "qvarlengtharray.h" // here or earlier - workaround for VC++6
 #include "qthread.h"
 #include "qmutex.h"
 #include "qunicodetables_p.h"
index b538e81..ed7c9fc 100644 (file)
@@ -64,7 +64,6 @@
 
 #include <qpainter_p.h>
 #include "qpaintengine.h"
-#include "qvarlengtharray.h"
 #include <qpaintengine_raster_p.h>
 #include <qnativeimage_p.h>
 
index 5b7b779..409edcb 100644 (file)
@@ -56,7 +56,6 @@
 
 #include "QtCore/qglobal.h"
 #include "QtCore/qatomic.h"
-#include <QtCore/qvarlengtharray.h>
 #include "qfont_p.h"
 
 #ifdef Q_WS_WIN
index 83c16c8..add332a 100644 (file)
@@ -61,7 +61,6 @@
 #include "QtCore/qlist.h"
 #include "QtCore/qmap.h"
 #include "QtCore/qpointer.h"
-#include "QtCore/qvarlengtharray.h"
 #include "QtCore/qdatastream.h"
 
 QT_BEGIN_NAMESPACE
index 748e810..9fe333a 100644 (file)
@@ -59,7 +59,6 @@
 #include <qstatusbar.h>
 #include <qstring.h>
 #include <qstyle.h>
-#include <qvarlengtharray.h>
 #include <qstack.h>
 #include <qmap.h>
 #include <qtimer.h>
index f024149..3ca63ab 100644 (file)
@@ -77,7 +77,6 @@
 #include <qpainter_p.h>
 #include <qfontengine_p.h>
 #include <qpixmapdata_gl_p.h>
-#include <qdatabuffer_p.h>
 #include <qstatictext_p.h>
 #include <qtriangulator_p.h>
 
index 75a225e..5dcb995 100644 (file)
@@ -46,8 +46,7 @@
 #include <QtGui/qpainter.h>
 #include <QtGui/qpainterpath.h>
 #include <QtGui/qbezier_p.h>
-// FIXME: generate <QtGui/qdatabuffer_p.h>
-#include <qdatabuffer_p.h>
+#include <QtGui/qdatabuffer_p.h>
 #include <QtCore/qbitarray.h>
 #include <QtCore/qvarlengtharray.h>
 #include <QtCore/qqueue.h>
index 52afa10..10360d5 100644 (file)
@@ -47,7 +47,6 @@
 #include <qevent.h>
 #include <qgl_p.h>
 #include <qcolormap.h>
-#include <qvarlengtharray.h>
 #include <qdebug.h>
 #include <qapplication.h>
 #include <qdesktopwidget>