OSDN Git Service

drivers: net: sun: cassini: use setup_timer() helper.
authorAllen Pais <allen.lkml@gmail.com>
Thu, 21 Sep 2017 17:04:42 +0000 (22:34 +0530)
committerDavid S. Miller <davem@davemloft.net>
Thu, 21 Sep 2017 18:44:40 +0000 (11:44 -0700)
Use setup_timer function instead of initializing timer with the
    function and data fields.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/sun/cassini.c

index 382993c..a74d78f 100644 (file)
@@ -5039,10 +5039,7 @@ static int cas_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
        spin_lock_init(&cp->stat_lock[N_TX_RINGS]);
        mutex_init(&cp->pm_mutex);
 
-       init_timer(&cp->link_timer);
-       cp->link_timer.function = cas_link_timer;
-       cp->link_timer.data = (unsigned long) cp;
-
+       setup_timer(&cp->link_timer, cas_link_timer, (unsigned long)cp);
 #if 1
        /* Just in case the implementation of atomic operations
         * change so that an explicit initialization is necessary.