OSDN Git Service

ASoC: rt5677: Add missing null check for failed allocation of rt5677_dsp
authorColin Ian King <colin.king@canonical.com>
Thu, 24 Oct 2019 12:46:10 +0000 (13:46 +0100)
committerMark Brown <broonie@kernel.org>
Fri, 25 Oct 2019 10:05:47 +0000 (11:05 +0100)
The allocation of rt5677_dsp can potentially fail and return null, so add
a null check and return -ENOMEM on a memory allocation failure.

Addresses-Coverity: ("Dereference null return")
Fixes: a0e0d135427c ("ASoC: rt5677: Add a PCM device for streaming hotword via SPI")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20191024124610.18182-1-colin.king@canonical.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt5677-spi.c

index 36c02d2..3a17643 100644 (file)
@@ -376,6 +376,8 @@ static int rt5677_spi_pcm_probe(struct snd_soc_component *component)
 
        rt5677_dsp = devm_kzalloc(component->dev, sizeof(*rt5677_dsp),
                        GFP_KERNEL);
+       if (!rt5677_dsp)
+               return -ENOMEM;
        rt5677_dsp->dev = &g_spi->dev;
        mutex_init(&rt5677_dsp->dma_lock);
        INIT_DELAYED_WORK(&rt5677_dsp->copy_work, rt5677_spi_copy_work);