OSDN Git Service

net/smc: avoid possible duplicate dmb unregistration
authorKarsten Graul <kgraul@linux.ibm.com>
Wed, 2 Jun 2021 08:56:25 +0000 (10:56 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 3 Jun 2021 20:54:49 +0000 (13:54 -0700)
smc_lgr_cleanup() calls smcd_unregister_all_dmbs() as part of the link
group termination process. This is a leftover from the times when
smc_lgr_cleanup() scheduled a worker to actually free the link group.
Nowadays smc_lgr_cleanup() directly calls smc_lgr_free() without any
delay so an earlier dmb unregistration is no longer needed.
So remove smcd_unregister_all_dmbs() and the call to it.

Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/smc/smc_core.c

index 0df85a1..317bc2c 100644 (file)
@@ -1235,20 +1235,6 @@ static void smc_lgr_free(struct smc_link_group *lgr)
        kfree(lgr);
 }
 
-static void smcd_unregister_all_dmbs(struct smc_link_group *lgr)
-{
-       int i;
-
-       for (i = 0; i < SMC_RMBE_SIZES; i++) {
-               struct smc_buf_desc *buf_desc;
-
-               list_for_each_entry(buf_desc, &lgr->rmbs[i], list) {
-                       buf_desc->len += sizeof(struct smcd_cdc_msg);
-                       smc_ism_unregister_dmb(lgr->smcd, buf_desc);
-               }
-       }
-}
-
 static void smc_sk_wake_ups(struct smc_sock *smc)
 {
        smc->sk.sk_write_space(&smc->sk);
@@ -1285,7 +1271,6 @@ static void smc_lgr_cleanup(struct smc_link_group *lgr)
 {
        if (lgr->is_smcd) {
                smc_ism_signal_shutdown(lgr);
-               smcd_unregister_all_dmbs(lgr);
        } else {
                u32 rsn = lgr->llc_termination_rsn;