OSDN Git Service

staging: greybus: audio_manager_sysfs: Replace sscanf with kstrto* to single variable...
authorElise Lennion <elise.lennion@gmail.com>
Fri, 14 Oct 2016 22:00:11 +0000 (19:00 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Oct 2016 13:35:03 +0000 (15:35 +0200)
Fix checkpatch warning:

WARNING: Prefer kstrto<type> to single variable sscanf

kstrto* is designed to convert string to numerical value and makes
it easier to understand what the code does.

Signed-off-by: Elise Lennion <elise.lennion@gmail.com>
Reviewed-by: Mark Greer <mgreer@animalcreek.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/greybus/audio_manager_sysfs.c

index fc0aca6..c6d82f9 100644 (file)
@@ -44,7 +44,7 @@ static ssize_t manager_sysfs_remove_store(
 {
        int id;
 
-       int num = sscanf(buf, "%d", &id);
+       int num = kstrtoint(buf, 10, &id);
 
        if (num != 1)
                return -EINVAL;
@@ -65,7 +65,7 @@ static ssize_t manager_sysfs_dump_store(
 {
        int id;
 
-       int num = sscanf(buf, "%d", &id);
+       int num = kstrtoint(buf, 10, &id);
 
        if (num == 1) {
                num = gb_audio_manager_dump_module(id);