OSDN Git Service
(root)
/
sagit-ice-cold
/
kernel_xiaomi_msm8998.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
1319518
)
ext4: use IS_ERR() to check for errors in ext4_error_file
author
Dan Carpenter
<error27@gmail.com>
Mon, 10 Jan 2011 17:10:50 +0000
(12:10 -0500)
committer
Theodore Ts'o
<tytso@mit.edu>
Mon, 10 Jan 2011 17:10:50 +0000
(12:10 -0500)
d_path() returns an ERR_PTR and it doesn't return NULL. This is in
ext4_error_file() and no one actually calls ext4_error_file().
Signed-off-by: Dan Carpenter <error27@gmail.com>
fs/ext4/super.c
patch
|
blob
|
history
diff --git
a/fs/ext4/super.c
b/fs/ext4/super.c
index
c228da1
..
d49e3b1
100644
(file)
--- a/
fs/ext4/super.c
+++ b/
fs/ext4/super.c
@@
-437,7
+437,7
@@
void ext4_error_file(struct file *file, const char *function,
save_error_info(inode->i_sb, function, line);
va_start(args, fmt);
path = d_path(&(file->f_path), pathname, sizeof(pathname));
- if (
!path
)
+ if (
IS_ERR(path)
)
path = "(unknown)";
printk(KERN_CRIT
"EXT4-fs error (device %s): %s:%d: inode #%lu "