OSDN Git Service

qdist: fix memory leak during binning
authorEmilio G. Cota <cota@braap.org>
Mon, 25 Jul 2016 15:03:43 +0000 (11:03 -0400)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 2 Aug 2016 10:03:58 +0000 (12:03 +0200)
In qdist_bin__internal(), to->entries is initialized to a 1-element array,
which we then leak when n == from->n. Fix it.

Signed-off-by: Emilio G. Cota <cota@braap.org>
Message-Id: <1469459025-23606-2-git-send-email-cota@braap.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
util/qdist.c

index 56f5738..eb2236c 100644 (file)
@@ -188,7 +188,7 @@ void qdist_bin__internal(struct qdist *to, const struct qdist *from, size_t n)
             }
         }
         /* they're equally spaced, so copy the dist and bail out */
-        to->entries = g_new(struct qdist_entry, from->n);
+        to->entries = g_realloc_n(to->entries, n, sizeof(*to->entries));
         to->n = from->n;
         memcpy(to->entries, from->entries, sizeof(*to->entries) * to->n);
         return;