OSDN Git Service

OPP: Use dev_err_probe() when failing to get icc_path
authorAndrew Halaney <ahalaney@redhat.com>
Fri, 23 Jun 2023 15:53:38 +0000 (10:53 -0500)
committerViresh Kumar <viresh.kumar@linaro.org>
Mon, 26 Jun 2023 06:40:26 +0000 (12:10 +0530)
This, in tandem with dynamic debug, can print useful information about
-EPROBE_DEFFER like below, and keeps similar behavior for other errors:

    [   16.561072] cpu cpu0: error -EPROBE_DEFER: dev_pm_opp_of_find_icc_paths: Unable to get path0
    [   16.575777] platform 18591000.cpufreq: deferred probe pending

Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/opp/of.c

index e6d1155..1f0923c 100644 (file)
@@ -513,11 +513,7 @@ int dev_pm_opp_of_find_icc_paths(struct device *dev,
        for (i = 0; i < num_paths; i++) {
                paths[i] = of_icc_get_by_index(dev, i);
                if (IS_ERR(paths[i])) {
-                       ret = PTR_ERR(paths[i]);
-                       if (ret != -EPROBE_DEFER) {
-                               dev_err(dev, "%s: Unable to get path%d: %d\n",
-                                       __func__, i, ret);
-                       }
+                       ret = dev_err_probe(dev, ret, "%s: Unable to get path%d\n", __func__, i);
                        goto err;
                }
        }