OSDN Git Service

selftests: net: reuseport_addr_any: silence clang warning
authorPeter Oskolkov <posk@google.com>
Fri, 21 Dec 2018 00:41:52 +0000 (16:41 -0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 21 Dec 2018 03:26:52 +0000 (19:26 -0800)
Clang does not recognize that calls to error() terminate execution
and complains about uninitialized variable use that happens after calls
to error(). This noop patchset fixes this.

Signed-off-by: Peter Oskolkov <posk@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
tools/testing/selftests/net/reuseport_addr_any.c

index 6f54d42..c623393 100644 (file)
@@ -60,6 +60,11 @@ static void build_rcv_fd(int family, int proto, int *rcv_fds, int count,
                break;
        default:
                error(1, 0, "Unsupported family %d", family);
+               /* clang does not recognize error() above as terminating
+                * the program, so it complains that saddr, sz are
+                * not initialized when this code path is taken. Silence it.
+                */
+               return;
        }
 
        for (i = 0; i < count; ++i) {
@@ -128,6 +133,11 @@ static int connect_and_send(int family, int proto)
        break;
        default:
                error(1, 0, "Unsupported family %d", family);
+               /* clang does not recognize error() above as terminating
+                * the program, so it complains that saddr, daddr, sz are
+                * not initialized when this code path is taken. Silence it.
+                */
+               return -1;
        }
 
        fd = socket(family, proto, 0);