OSDN Git Service

hwmon: (lm87) Fix vrm write operation
authorAxel Lin <axel.lin@ingics.com>
Wed, 6 Aug 2014 00:24:00 +0000 (08:24 +0800)
committerGuenter Roeck <linux@roeck-us.net>
Wed, 6 Aug 2014 02:44:42 +0000 (19:44 -0700)
vrm is an u8, so the written value needs to be limited to [0, 255].

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/lm87.c

index ba1d83d..a5e2958 100644 (file)
@@ -617,6 +617,10 @@ static ssize_t set_vrm(struct device *dev, struct device_attribute *attr,
        err = kstrtoul(buf, 10, &val);
        if (err)
                return err;
+
+       if (val > 255)
+               return -EINVAL;
+
        data->vrm = val;
        return count;
 }