OSDN Git Service

platform/x86: alienware-wmi: printing the wrong error code
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 24 Apr 2019 09:44:18 +0000 (12:44 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Jan 2020 09:21:43 +0000 (10:21 +0100)
[ Upstream commit 6d1f8b3d75419a8659ac916a1e9543bb3513a882 ]

The "out_data" variable is uninitialized at the point.  Originally, this
used to print "status" instead and that seems like the correct thing to
print.

Fixes: bc2ef884320b ("alienware-wmi: For WMAX HDMI method, introduce a way to query HDMI cable status")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Mario Limonciello <mario.limonciello@dell.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/platform/x86/alienware-wmi.c

index 3df47c1..f558574 100644 (file)
@@ -511,7 +511,7 @@ static ssize_t show_hdmi_source(struct device *dev,
                        return scnprintf(buf, PAGE_SIZE,
                                         "input [gpu] unknown\n");
        }
-       pr_err("alienware-wmi: unknown HDMI source status: %d\n", out_data);
+       pr_err("alienware-wmi: unknown HDMI source status: %u\n", status);
        return scnprintf(buf, PAGE_SIZE, "input gpu [unknown]\n");
 }