OSDN Git Service

IB: Ensure that all rdma_ah_attr's are zero initialized
authorParav Pandit <parav@mellanox.com>
Wed, 13 Jun 2018 07:22:02 +0000 (10:22 +0300)
committerJason Gunthorpe <jgg@mellanox.com>
Mon, 18 Jun 2018 17:11:26 +0000 (11:11 -0600)
Since we are adding some new fields to this structure it is safest if all
users reliably initialize the struct to zero.

Signed-off-by: Parav Pandit <parav@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
drivers/infiniband/core/uverbs_cmd.c

index 72803f8..5733d0f 100644 (file)
@@ -1968,7 +1968,7 @@ static int modify_qp(struct ib_uverbs_file *file,
        struct ib_qp *qp;
        int ret;
 
-       attr = kmalloc(sizeof *attr, GFP_KERNEL);
+       attr = kzalloc(sizeof(*attr), GFP_KERNEL);
        if (!attr)
                return -ENOMEM;
 
@@ -2552,7 +2552,7 @@ ssize_t ib_uverbs_create_ah(struct ib_uverbs_file *file,
        struct ib_uobject               *uobj;
        struct ib_pd                    *pd;
        struct ib_ah                    *ah;
-       struct rdma_ah_attr             attr;
+       struct rdma_ah_attr             attr = {};
        int ret;
        struct ib_udata                   udata;