OSDN Git Service

hwrng: pixocell - Use devm_ioremap_resource()
authorJingoo Han <jg1.han@samsung.com>
Wed, 12 Feb 2014 05:19:48 +0000 (14:19 +0900)
committerHerbert Xu <herbert@gondor.apana.org.au>
Wed, 26 Feb 2014 21:56:51 +0000 (05:56 +0800)
Use devm_ioremap_resource() in order to make the code simpler,
and remove redundant return value check of platform_get_resource()
because the value is checked by devm_ioremap_resource().

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/char/hw_random/picoxcell-rng.c

index 3d4c229..c03beee 100644 (file)
@@ -104,22 +104,9 @@ static int picoxcell_trng_probe(struct platform_device *pdev)
        int ret;
        struct resource *mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 
-       if (!mem) {
-               dev_warn(&pdev->dev, "no memory resource\n");
-               return -ENOMEM;
-       }
-
-       if (!devm_request_mem_region(&pdev->dev, mem->start, resource_size(mem),
-                                    "picoxcell_trng")) {
-               dev_warn(&pdev->dev, "unable to request io mem\n");
-               return -EBUSY;
-       }
-
-       rng_base = devm_ioremap(&pdev->dev, mem->start, resource_size(mem));
-       if (!rng_base) {
-               dev_warn(&pdev->dev, "unable to remap io mem\n");
-               return -ENOMEM;
-       }
+       rng_base = devm_ioremap_resource(&pdev->dev, mem);
+       if (IS_ERR(rng_base))
+               return PTR_ERR(rng_base);
 
        rng_clk = clk_get(&pdev->dev, NULL);
        if (IS_ERR(rng_clk)) {