OSDN Git Service

Model::Stories: fix introtext parameter check in create()
authorhylom <hylom@users.osdn.me>
Wed, 5 Jun 2019 06:49:03 +0000 (06:49 +0000)
committerhylom <hylom@users.osdn.me>
Wed, 5 Jun 2019 06:49:03 +0000 (06:49 +0000)
src/newslash_web/lib/Newslash/Model/Stories.pm
src/newslash_web/t/models/submissions.t

index de277e5..1dbd836 100644 (file)
@@ -547,7 +547,7 @@ sub create {
     # check parameters
     my $msg = "";
     $msg = "no_title" if !$params->{title};
-    $msg = "no_introtext" if !$params->{introtext} || $params->{intro_text};
+    $msg = "no_introtext" if !$params->{introtext} && !$params->{intro_text};
     $msg = "no_topics" if !defined $params->{topics_chosen};
     $msg = "invalid_user" if !defined $user->{uid};
 
index e459547..313a793 100644 (file)
@@ -28,7 +28,7 @@ subtest 'create/select/update submissions' => sub {
 
     my $params = {
                   user => $user,
-                  title => "test story",
+                  title => "test story for submission",
                   url => "http://example.com/",
                   email => 'foo@example.com',
                   introtext => '<p>foo bar hoge</p>',
@@ -39,6 +39,7 @@ subtest 'create/select/update submissions' => sub {
                  };
     my $subid = $submissions->create(%$params);
     ok($subid, "create submission");
+    diag $submissions->last_error if !$subid;
 
     my $subm = $submissions->select(submission_id => $subid);
     ok($subm, "select story by submission_id");