OSDN Git Service

fsi: master-hub: Fix sparse warnings
authorJoel Stanley <joel@jms.id.au>
Mon, 18 Jun 2018 03:43:34 +0000 (13:13 +0930)
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>
Mon, 18 Jun 2018 04:33:56 +0000 (14:33 +1000)
fsi-master-hub.c:128:13: warning: incorrect type in assignment (different base types)
fsi-master-hub.c:128:13:    expected unsigned int [unsigned] [usertype] cmd
fsi-master-hub.c:128:13:    got restricted __be32 [usertype] <noident>
fsi-master-hub.c:208:13: warning: incorrect type in assignment (different base types)
fsi-master-hub.c:208:13:    expected restricted __be32 [addressable] [assigned] [usertype] reg
fsi-master-hub.c:208:13:    got int

Signed-off-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
drivers/fsi/fsi-master-hub.c

index 5885fc4..b3c1e9d 100644 (file)
@@ -122,7 +122,8 @@ static int hub_master_write(struct fsi_master *master, int link,
 
 static int hub_master_break(struct fsi_master *master, int link)
 {
-       uint32_t addr, cmd;
+       uint32_t addr;
+       __be32 cmd;
 
        addr = 0x4;
        cmd = cpu_to_be32(0xc0de0000);
@@ -205,7 +206,7 @@ static int hub_master_init(struct fsi_master_hub *hub)
        if (rc)
                return rc;
 
-       reg = ~0;
+       reg = cpu_to_be32(~0);
        rc = fsi_device_write(dev, FSI_MSENP0, &reg, sizeof(reg));
        if (rc)
                return rc;