OSDN Git Service

net: hns3: delete unnecessary logs after kzalloc fails
authorYufeng Mo <moyufeng@huawei.com>
Sat, 7 Mar 2020 03:42:50 +0000 (11:42 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 10 Mar 2020 02:36:13 +0000 (19:36 -0700)
Since kernel already has logs after kzalloc fails,
it's unnecessary to print duplicate logs. So this
patch deletes these logs.

Signed-off-by: Yufeng Mo <moyufeng@huawei.com>
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c

index 07b30f9..1722828 100644 (file)
@@ -145,10 +145,8 @@ static void hclge_dbg_dump_reg_common(struct hclge_dev *hdev,
 
        buf_len = sizeof(struct hclge_desc) * bd_num;
        desc_src = kzalloc(buf_len, GFP_KERNEL);
-       if (!desc_src) {
-               dev_err(&hdev->pdev->dev, "call kzalloc failed\n");
+       if (!desc_src)
                return;
-       }
 
        desc = desc_src;
        ret = hclge_dbg_cmd_send(hdev, desc, index, bd_num, reg_msg->cmd);
@@ -1082,11 +1080,8 @@ static void hclge_dbg_get_m7_stats_info(struct hclge_dev *hdev)
 
        buf_len  = sizeof(struct hclge_desc) * bd_num;
        desc_src = kzalloc(buf_len, GFP_KERNEL);
-       if (!desc_src) {
-               dev_err(&hdev->pdev->dev,
-                       "allocate desc for get_m7_stats failed\n");
+       if (!desc_src)
                return;
-       }
 
        desc_tmp = desc_src;
        ret  = hclge_dbg_cmd_send(hdev, desc_tmp, 0, bd_num,