android: add HAVE_VISIBILITY to Android.common.mk

Currently only libdrm.so properly annotates its internal/private
symbols. By setting the macro every binary produced will be in the same
boat. This should give is smaller and more secure files

Cc: Chih-Wei Huang <cwhuang@android-x86.org>
Cc: Rob Herring <robh@kernel.org>
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Rob Herring <robh@kernel.org>

diff --git a/Android.common.mk b/Android.common.mk
index c6ab8f5..ffe9219 100644 (file)
--- a/Android.common.mk
+++ b/Android.common.mk
@@ -1,4 +1,5 @@
 LOCAL_CFLAGS += \
+       -DHAVE_VISIBILITY=1 \
        -DHAVE_LIBDRM_ATOMIC_PRIMITIVES=1
 
 # Quiet down the build system and remove any .h files from the sources

diff --git a/Android.mk b/Android.mk
index ec6d532..5209059 100644 (file)
--- a/Android.mk
+++ b/Android.mk
@@ -41,9 +41,6 @@ LOCAL_EXPORT_C_INCLUDE_DIRS := \
 LOCAL_C_INCLUDES := \
        $(LOCAL_PATH)/include/drm
 
-LOCAL_CFLAGS := \
-       -DHAVE_VISIBILITY=1
-
 include $(LIBDRM_COMMON_MK)
 include $(BUILD_STATIC_LIBRARY)
 
@@ -58,9 +55,6 @@ LOCAL_EXPORT_C_INCLUDE_DIRS := \
 LOCAL_C_INCLUDES := \
         $(LOCAL_PATH)/include/drm
 
-LOCAL_CFLAGS := \
-       -DHAVE_VISIBILITY=1
-
 include $(LIBDRM_COMMON_MK)
 include $(BUILD_SHARED_LIBRARY)