OSDN Git Service

selftests: bpf: Less strict size check in sockopt_sk
authorFelix Maurer <fmaurer@redhat.com>
Tue, 25 Jan 2022 16:58:23 +0000 (17:58 +0100)
committerAlexei Starovoitov <ast@kernel.org>
Wed, 26 Jan 2022 02:25:05 +0000 (18:25 -0800)
Originally, the kernel strictly checked the size of the optval in
getsockopt(TCP_ZEROCOPY_RECEIVE) to be equal to sizeof(struct
tcp_zerocopy_receive). With c8856c0514549, this was changed to allow
optvals of different sizes.

The bpf code in the sockopt_sk test was still performing the strict size
check. This fix adapts the kernel behavior from c8856c0514549 in the
selftest, i.e., just check if the required fields are there.

Fixes: 9cacf81f81611 ("bpf: Remove extra lock_sock for TCP_ZEROCOPY_RECEIVE")
Signed-off-by: Felix Maurer <fmaurer@redhat.com>
Reviewed-by: Stanislav Fomichev <sdf@google.com>
Link: https://lore.kernel.org/r/6f569cca2e45473f9a724d54d03fdfb45f29e35f.1643129402.git.fmaurer@redhat.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
tools/testing/selftests/bpf/progs/sockopt_sk.c

index d0298dc..c8d8100 100644 (file)
@@ -72,7 +72,8 @@ int _getsockopt(struct bpf_sockopt *ctx)
                 * reasons.
                 */
 
-               if (optval + sizeof(struct tcp_zerocopy_receive) > optval_end)
+               /* Check that optval contains address (__u64) */
+               if (optval + sizeof(__u64) > optval_end)
                        return 0; /* bounds check */
 
                if (((struct tcp_zerocopy_receive *)optval)->address != 0)