OSDN Git Service

staging: mt7621-pci-phy: use 'platform_get_resource'
authorSergio Paracuellos <sergio.paracuellos@gmail.com>
Wed, 17 Apr 2019 11:58:35 +0000 (13:58 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 19 Apr 2019 13:01:33 +0000 (15:01 +0200)
Driver is using 'of_address_to_resource' to get memory resources.
Make use of 'platform_get_resource' instead which is more accurate
for a platform driver. This also makes possible to delete a local
variable which is not needed anymore.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c

index aa3ae77..bac188f 100644 (file)
@@ -308,11 +308,10 @@ static struct phy *mt7621_pcie_phy_of_xlate(struct device *dev,
 static int mt7621_pci_phy_probe(struct platform_device *pdev)
 {
        struct device *dev = &pdev->dev;
-       struct device_node *np = dev->of_node;
        struct device_node *child_np;
        struct phy_provider *provider;
        struct mt7621_pci_phy *phy;
-       struct resource res;
+       struct resource *res;
        int port, ret;
        void __iomem *port_base;
 
@@ -329,13 +328,13 @@ static int mt7621_pci_phy_probe(struct platform_device *pdev)
        phy->dev = dev;
        platform_set_drvdata(pdev, phy);
 
-       ret = of_address_to_resource(np, 0, &res);
-       if (ret) {
+       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+       if (!res) {
                dev_err(dev, "failed to get address resource\n");
-               return ret;
+               return -ENXIO;
        }
 
-       port_base = devm_ioremap_resource(dev, &res);
+       port_base = devm_ioremap_resource(dev, res);
        if (IS_ERR(port_base)) {
                dev_err(dev, "failed to remap phy regs\n");
                return PTR_ERR(port_base);