OSDN Git Service

pwm: bcm-kona: Use pwmchip_add() instead of pwmchip_add_with_polarity()
authorUwe Kleine-König <uwe@kleine-koenig.org>
Mon, 7 Dec 2020 13:45:54 +0000 (14:45 +0100)
committerThierry Reding <thierry.reding@gmail.com>
Mon, 22 Mar 2021 11:18:54 +0000 (12:18 +0100)
The only side effect of this change is that pwm->state.polarity is
initialized to PWM_POLARITY_NORMAL instead of PWM_POLARITY_INVERSED.
However all other members of pwm->state are uninitialized and consumers
are expected to provide the right polarity (either by setting it explicitly
or by using a helper like pwm_init_state() that overwrites .polarity
anyhow with a value independent of the initial value).

The eventual goal is to remove pwmchip_add_with_polarity() and so simplify
the data flow in the PWM core.

Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-bcm-kona.c

index 2e8aede..f09a310 100644 (file)
@@ -300,7 +300,7 @@ static int kona_pwmc_probe(struct platform_device *pdev)
 
        clk_disable_unprepare(kp->clk);
 
-       ret = pwmchip_add_with_polarity(&kp->chip, PWM_POLARITY_INVERSED);
+       ret = pwmchip_add(&kp->chip);
        if (ret < 0)
                dev_err(&pdev->dev, "failed to add PWM chip: %d\n", ret);