OSDN Git Service
(root)
/
uclinux-h8
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
7a4af4b
)
platform/x86: x86-android-tablets: Don't return -EPROBE_DEFER from a non probe()...
author
Hans de Goede
<hdegoede@redhat.com>
Wed, 29 Dec 2021 23:14:23 +0000
(
00:14
+0100)
committer
Hans de Goede
<hdegoede@redhat.com>
Wed, 5 Jan 2022 10:31:18 +0000
(11:31 +0100)
The x86-android-tablets code all runs from module_init, so returning
-EPROBE_DEFER is not appropriate. Instead log an error and bail.
This path should never get hit since PINCTRL_BAYTRAIL is a bool.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link:
https://lore.kernel.org/r/20211229231431.437982-5-hdegoede@redhat.com
drivers/platform/x86/x86-android-tablets.c
patch
|
blob
|
history
diff --git
a/drivers/platform/x86/x86-android-tablets.c
b/drivers/platform/x86/x86-android-tablets.c
index
4a04da2
..
ea033d7
100644
(file)
--- a/
drivers/platform/x86/x86-android-tablets.c
+++ b/
drivers/platform/x86/x86-android-tablets.c
@@
-63,8
+63,10
@@
static int x86_acpi_irq_helper_get(const struct x86_acpi_irq_data *data)
case X86_ACPI_IRQ_TYPE_GPIOINT:
/* Like acpi_dev_gpio_irq_get(), but without parsing ACPI resources */
chip = gpiochip_find(data->chip, x86_acpi_irq_helper_gpiochip_find);
- if (!chip)
- return -EPROBE_DEFER;
+ if (!chip) {
+ pr_err("error cannot find GPIO chip %s\n", data->chip);
+ return -ENODEV;
+ }
gpiod = gpiochip_get_desc(chip, data->index);
if (IS_ERR(gpiod)) {