OSDN Git Service

QmlJS checks: Make 'unintentional empty block' warning less annoying.
authorChristian Kamm <christian.d.kamm@nokia.com>
Mon, 24 Oct 2011 08:20:19 +0000 (10:20 +0200)
committerChristian Kamm <christian.d.kamm@nokia.com>
Mon, 24 Oct 2011 08:23:19 +0000 (10:23 +0200)
Already fixed differently in master.

Change-Id: I92f7665166b2b1ca4f3d4598825b04f3f19d4772
Reviewed-by: Christian Kamm <christian.d.kamm@nokia.com>
src/libs/qmljs/qmljscheck.cpp

index d4c6ae1..486adde 100644 (file)
@@ -970,8 +970,7 @@ bool Check::visit(Block *ast)
             warning(ast->lbraceToken, tr("blocks do not introduce a new scope, avoid"));
         }
         if (!ast->statements
-                && (cast<UiPublicMember *>(p)
-                    || cast<UiScriptBinding *>(p))) {
+                && cast<UiPublicMember *>(p)) {
             warning(locationFromRange(ast->firstSourceLocation(), ast->lastSourceLocation()),
                     tr("unintentional empty block, use ({}) for empty object literal"));
         }