OSDN Git Service

mmc: mediatek: fix cannot receive new request when msdc_cmd_is_ready fail
authorChaotian Jing <chaotian.jing@mediatek.com>
Sat, 13 Oct 2018 07:20:47 +0000 (15:20 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 27 Nov 2019 20:23:50 +0000 (21:23 +0100)
[ Upstream commit f38a9774ddde9d79b3487dd888edd8b8623552af ]

when msdc_cmd_is_ready return fail, the req_timeout work has not been
inited and cancel_delayed_work() will return false, then, the request
return directly and never call mmc_request_done().

so need call mod_delayed_work() before msdc_cmd_is_ready()

Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mmc/host/mtk-sd.c

index 0bf0d0e..5ef2546 100644 (file)
@@ -846,6 +846,7 @@ static void msdc_start_command(struct msdc_host *host,
        WARN_ON(host->cmd);
        host->cmd = cmd;
 
+       mod_delayed_work(system_wq, &host->req_timeout, DAT_TIMEOUT);
        if (!msdc_cmd_is_ready(host, mrq, cmd))
                return;
 
@@ -857,7 +858,6 @@ static void msdc_start_command(struct msdc_host *host,
 
        cmd->error = 0;
        rawcmd = msdc_cmd_prepare_raw_cmd(host, mrq, cmd);
-       mod_delayed_work(system_wq, &host->req_timeout, DAT_TIMEOUT);
 
        sdr_set_bits(host->base + MSDC_INTEN, cmd_ints_mask);
        writel(cmd->arg, host->base + SDC_ARG);