HID: playstation: expose DualSense lightbar through a multi-color LED.

The DualSense lightbar has so far been supported, but it was not yet
adjustable from user space. This patch exposes it through a multi-color
LED.

Signed-off-by: Roderick Colenbrander <roderick.colenbrander@sony.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

diff --git a/drivers/hid/hid-playstation.c b/drivers/hid/hid-playstation.c
index ab7c82c..ff2fc31 100644 (file)
--- a/drivers/hid/hid-playstation.c
+++ b/drivers/hid/hid-playstation.c
@@ -11,6 +11,8 @@
 #include <linux/hid.h>
 #include <linux/idr.h>
 #include <linux/input/mt.h>
+#include <linux/leds.h>
+#include <linux/led-class-multicolor.h>
 #include <linux/module.h>
 
 #include <asm/unaligned.h>
@@ -38,6 +40,7 @@ struct ps_device {
        uint8_t battery_capacity;
        int battery_status;
 
+       const char *input_dev_name; /* Name of primary input device. */
        uint8_t mac_address[6]; /* Note: stored in little endian order. */
        uint32_t hw_version;
        uint32_t fw_version;
@@ -147,6 +150,7 @@ struct dualsense {
        uint8_t motor_right;
 
        /* RGB lightbar */
+       struct led_classdev_mc lightbar;
        bool update_lightbar;
        uint8_t lightbar_red;
        uint8_t lightbar_green;
@@ -288,6 +292,8 @@ static const struct {int x; int y; } ps_gamepad_hat_mapping[] = {
        {0, 0},
 };
 
+static void dualsense_set_lightbar(struct dualsense *ds, uint8_t red, uint8_t green, uint8_t blue);
+
 /*
  * Add a new ps_device to ps_devices if it doesn't exist.
  * Return error on duplicate device, which can happen if the same
@@ -525,6 +531,45 @@ static int ps_get_report(struct hid_device *hdev, uint8_t report_id, uint8_t *bu
        return 0;
 }
 
+/* Register a DualSense/DualShock4 RGB lightbar represented by a multicolor LED. */
+static int ps_lightbar_register(struct ps_device *ps_dev, struct led_classdev_mc *lightbar_mc_dev,
+       int (*brightness_set)(struct led_classdev *, enum led_brightness))
+{
+       struct hid_device *hdev = ps_dev->hdev;
+       struct mc_subled *mc_led_info;
+       struct led_classdev *led_cdev;
+       int ret;
+
+       mc_led_info = devm_kmalloc_array(&hdev->dev, 3, sizeof(*mc_led_info),
+                                        GFP_KERNEL | __GFP_ZERO);
+       if (!mc_led_info)
+               return -ENOMEM;
+
+       mc_led_info[0].color_index = LED_COLOR_ID_RED;
+       mc_led_info[1].color_index = LED_COLOR_ID_GREEN;
+       mc_led_info[2].color_index = LED_COLOR_ID_BLUE;
+
+       lightbar_mc_dev->subled_info = mc_led_info;
+       lightbar_mc_dev->num_colors = 3;
+
+       led_cdev = &lightbar_mc_dev->led_cdev;
+       led_cdev->name = devm_kasprintf(&hdev->dev, GFP_KERNEL, "%s:rgb:indicator",
+                       ps_dev->input_dev_name);
+       if (!led_cdev->name)
+               return -ENOMEM;
+       led_cdev->brightness = 255;
+       led_cdev->max_brightness = 255;
+       led_cdev->brightness_set_blocking = brightness_set;
+
+       ret = devm_led_classdev_multicolor_register(&hdev->dev, lightbar_mc_dev);
+       if (ret < 0) {
+               hid_err(hdev, "Cannot register multicolor LED device\n");
+               return ret;
+       }
+
+       return 0;
+}
+
 static struct input_dev *ps_sensors_create(struct hid_device *hdev, int accel_range, int accel_res,
                int gyro_range, int gyro_res)
 {
@@ -761,6 +806,22 @@ err_free:
        return ret;
 }
 
+static int dualsense_lightbar_set_brightness(struct led_classdev *cdev,
+       enum led_brightness brightness)
+{
+       struct led_classdev_mc *mc_cdev = lcdev_to_mccdev(cdev);
+       struct dualsense *ds = container_of(mc_cdev, struct dualsense, lightbar);
+       uint8_t red, green, blue;
+
+       led_mc_calc_color_components(mc_cdev, brightness);
+       red = mc_cdev->subled_info[0].brightness;
+       green = mc_cdev->subled_info[1].brightness;
+       blue = mc_cdev->subled_info[2].brightness;
+
+       dualsense_set_lightbar(ds, red, green, blue);
+       return 0;
+}
+
 static void dualsense_init_output_report(struct dualsense *ds, struct dualsense_output_report *rp,
                void *buf)
 {
@@ -1106,10 +1167,14 @@ static int dualsense_reset_leds(struct dualsense *ds)
 
 static void dualsense_set_lightbar(struct dualsense *ds, uint8_t red, uint8_t green, uint8_t blue)
 {
+       unsigned long flags;
+
+       spin_lock_irqsave(&ds->base.lock, flags);
        ds->update_lightbar = true;
        ds->lightbar_red = red;
        ds->lightbar_green = green;
        ds->lightbar_blue = blue;
+       spin_unlock_irqrestore(&ds->base.lock, flags);
 
        schedule_work(&ds->output_worker);
 }
@@ -1196,6 +1261,8 @@ static struct ps_device *dualsense_create(struct hid_device *hdev)
                ret = PTR_ERR(ds->gamepad);
                goto err;
        }
+       /* Use gamepad input device name as primary device name for e.g. LEDs */
+       ps_dev->input_dev_name = dev_name(&ds->gamepad->dev);
 
        ds->sensors = ps_sensors_create(hdev, DS_ACC_RANGE, DS_ACC_RES_PER_G,
                        DS_GYRO_RANGE, DS_GYRO_RES_PER_DEG_S);
@@ -1223,6 +1290,11 @@ static struct ps_device *dualsense_create(struct hid_device *hdev)
        if (ret)
                goto err;
 
+       ret = ps_lightbar_register(ps_dev, &ds->lightbar, dualsense_lightbar_set_brightness);
+       if (ret)
+               goto err;
+
+       /* Set default lightbar color. */
        dualsense_set_lightbar(ds, 0, 0, 128); /* blue */
 
        ret = ps_device_set_player_id(ps_dev);