OSDN Git Service

net: dsa: sja1105: Remove unneeded cast in sja1105_crc32()
authorGeert Uytterhoeven <geert+renesas@glider.be>
Tue, 23 Feb 2021 11:20:03 +0000 (12:20 +0100)
committerJakub Kicinski <kuba@kernel.org>
Thu, 25 Feb 2021 17:41:32 +0000 (09:41 -0800)
sja1105_unpack() takes a "const void *buf" as its first parameter, so
there is no need to cast away the "const" of the "buf" variable before
calling it.

Drop the cast, as it prevents the compiler performing some checks.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Link: https://lore.kernel.org/r/20210223112003.2223332-1-geert+renesas@glider.be
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/sja1105/sja1105_static_config.c

index 139b7b4..a8efb7f 100644 (file)
@@ -85,7 +85,7 @@ u32 sja1105_crc32(const void *buf, size_t len)
        /* seed */
        crc = ~0;
        for (i = 0; i < len; i += 4) {
-               sja1105_unpack((void *)buf + i, &word, 31, 0, 4);
+               sja1105_unpack(buf + i, &word, 31, 0, 4);
                crc = crc32_le(crc, (u8 *)&word, 4);
        }
        return ~crc;