OSDN Git Service

mwifiex: potential corruption in mwifiex_update_uap_custom_ie()
authorDan Carpenter <dan.carpenter@oracle.com>
Sun, 23 Sep 2012 16:33:00 +0000 (19:33 +0300)
committerJohn W. Linville <linville@tuxdriver.com>
Tue, 25 Sep 2012 19:57:43 +0000 (15:57 -0400)
ap_custom_ie is a struct mwifiex_ie_list which is quite different and
also larger than struct mwifiex_ie.  It's a difference between 4196
bytes and 262.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Tested-by: Stone Piao <piaoyun@marvell.com>
Acked-by: Bing Zhao <bzhao@marvell.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/mwifiex/ie.c

index 1d8dd00..fa3a80f 100644 (file)
@@ -160,7 +160,7 @@ mwifiex_update_uap_custom_ie(struct mwifiex_private *priv,
        u16 len;
        int ret;
 
-       ap_custom_ie = kzalloc(sizeof(struct mwifiex_ie), GFP_KERNEL);
+       ap_custom_ie = kzalloc(sizeof(*ap_custom_ie), GFP_KERNEL);
        if (!ap_custom_ie)
                return -ENOMEM;