OSDN Git Service

drm/i915: fix use of uninitialized pointer vaddr
authorColin Ian King <colin.king@canonical.com>
Fri, 31 May 2019 10:32:01 +0000 (11:32 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Fri, 31 May 2019 10:40:00 +0000 (11:40 +0100)
The assignment of err is using the incorrect pointer vaddr that has
not been initialized. Fix this by using the correct pointer obj instead.

Addresses-Coverity: ("Uninitialized pointer read")
Fixes: 6501aa4e3a45 ("drm/i915: add in-kernel blitter client")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20190531103201.10124-1-colin.king@canonical.com
drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c

index 8de568d..e23d8c9 100644 (file)
@@ -32,7 +32,7 @@ static int igt_fill_blt(void *arg)
 
                obj = i915_gem_object_create_internal(i915, sz);
                if (IS_ERR(obj)) {
-                       err = PTR_ERR(vaddr);
+                       err = PTR_ERR(obj);
                        goto err_flush;
                }