OSDN Git Service

tipc: fix link name length check
authorJohn Rutherford <john.rutherford@dektech.com.au>
Tue, 26 Nov 2019 02:52:55 +0000 (13:52 +1100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 26 Nov 2019 18:03:12 +0000 (10:03 -0800)
In commit 4f07b80c9733 ("tipc: check msg->req data len in
tipc_nl_compat_bearer_disable") the same patch code was copied into
routines: tipc_nl_compat_bearer_disable(),
tipc_nl_compat_link_stat_dump() and tipc_nl_compat_link_reset_stats().
The two link routine occurrences should have been modified to check
the maximum link name length and not bearer name length.

Fixes: 4f07b80c9733 ("tipc: check msg->reg data len in tipc_nl_compat_bearer_disable")
Signed-off-by: John Rutherford <john.rutherford@dektech.com.au>
Acked-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tipc/netlink_compat.c

index 17a5297..0254bb7 100644 (file)
@@ -570,7 +570,7 @@ static int tipc_nl_compat_link_stat_dump(struct tipc_nl_compat_msg *msg,
        if (len <= 0)
                return -EINVAL;
 
-       len = min_t(int, len, TIPC_MAX_BEARER_NAME);
+       len = min_t(int, len, TIPC_MAX_LINK_NAME);
        if (!string_is_valid(name, len))
                return -EINVAL;
 
@@ -842,7 +842,7 @@ static int tipc_nl_compat_link_reset_stats(struct tipc_nl_compat_cmd_doit *cmd,
        if (len <= 0)
                return -EINVAL;
 
-       len = min_t(int, len, TIPC_MAX_BEARER_NAME);
+       len = min_t(int, len, TIPC_MAX_LINK_NAME);
        if (!string_is_valid(name, len))
                return -EINVAL;