OSDN Git Service

drm/stm: ltdc: remove clk_round_rate comment
authorYannick Fertré <yannick.fertre@st.com>
Fri, 10 May 2019 15:03:20 +0000 (17:03 +0200)
committerBenjamin Gaignard <benjamin.gaignard@linaro.org>
Fri, 24 May 2019 08:30:46 +0000 (10:30 +0200)
Clk_round_rate returns rounded clock without changing
the hardware in any way.
This function couldn't replace set_rate/get_rate calls.
Todo comment has been removed & a new log inserted.

Signed-off-by: Yannick Fertré <yannick.fertre@st.com>
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/1557500600-19771-1-git-send-email-yannick.fertre@st.com
drivers/gpu/drm/stm/ltdc.c

index 14eb8c4..ae2aaf2 100644 (file)
@@ -507,20 +507,16 @@ static bool ltdc_crtc_mode_fixup(struct drm_crtc *crtc,
        struct ltdc_device *ldev = crtc_to_ltdc(crtc);
        int rate = mode->clock * 1000;
 
-       /*
-        * TODO clk_round_rate() does not work yet. When ready, it can
-        * be used instead of clk_set_rate() then clk_get_rate().
-        */
-
-       clk_disable(ldev->pixel_clk);
        if (clk_set_rate(ldev->pixel_clk, rate) < 0) {
                DRM_ERROR("Cannot set rate (%dHz) for pixel clk\n", rate);
                return false;
        }
-       clk_enable(ldev->pixel_clk);
 
        adjusted_mode->clock = clk_get_rate(ldev->pixel_clk) / 1000;
 
+       DRM_DEBUG_DRIVER("requested clock %dkHz, adjusted clock %dkHz\n",
+                        mode->clock, adjusted_mode->clock);
+
        return true;
 }